Added toggleswallow dispatcher
#5548
Conversation
| @@ -687,10 +688,16 @@ void Events::listener_unmapWindow(void* owner, void* data) { | |||
| g_pHyprOpenGL->makeWindowSnapshot(PWINDOW); | |||
|
|
|||
| // swallowing | |||
| if (PWINDOW->m_pSwallowed && g_pCompositor->windowExists(PWINDOW->m_pSwallowed)) { | |||
| if (PWINDOW->m_pSwallowed) { | |||
There was a problem hiding this comment.
what about previouslySwallowed? Also reset this :P
Generally I see no point in the "previously" member as the "swallowed" member shouldnt change anything. Just hide and unhide I'd say
There was a problem hiding this comment.
Replaced with a bool. Is there a better method to handle the hide and unhide in C++ ?
There was a problem hiding this comment.
why not check isHidden()? If swallowed != null and swallowed->ishidden(), it's swallowed, if it's not hidden, it's not
There was a problem hiding this comment.
I thought about this, but it could be hidden for other reasons, like if another window is fullscreen, no ?
There was a problem hiding this comment.
grouped windows are hidden
vaxerski
force-pushed
the
main
branch
9 times, most recently
from
7110a04
to
25aec3a
Compare
vaxerski
force-pushed
the
main
branch
2 times, most recently
from
fb471b8
to
1237732
Compare
vaxerski
force-pushed
the
main
branch
2 times, most recently
from
358e59e
to
3fd6c1b
Compare
vaxerski
force-pushed
the
main
branch
2 times, most recently
from
1184395
to
b16fb97
Compare
|
Would love to see this coming online :) |
Describe your PR, what does it fix/add?
New feature:
toggleswallowdispatcher which allows to toggle the swallowed window with a keybind. Only if the window was originally swallowed will it work. Meaning that you can only "unswallow" and then "swallow" again a window, and so on.Useful when you want to have your terminal swallowed, but sometimes you also want to check the logs of your running application.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Ready