compositor: fix ghost fadingOut windows remaining after cleanup

hyprwm · Apr 6, 2024 · 80f8524 · 80f8524
1 parent 6e4c15e
commit 80f8524
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/src/Compositor.cpp b/src/Compositor.cpp
@@ -1459,19 +1459,14 @@ void CCompositor::cleanupFadingOut(const int& monid) {
         if (w->m_iMonitorID != (long unsigned int)monid)
             continue;
 
-        bool valid = windowExists(w);
+        if (!w->m_bFadingOut || w->m_fAlpha.value() == 0.f) {
 
-        if (!valid || !w->m_bFadingOut || w->m_fAlpha.value() == 0.f) {
-            if (valid) {
-                w->m_bFadingOut = false;
+            w->m_bFadingOut = false;
 
-                if (!w->m_bReadyToDelete)
-                    continue;
-
-                removeWindowFromVectorSafe(w);
-            }
+            if (!w->m_bReadyToDelete)
+                continue;
 
-            std::erase(m_vWindowsFadingOut, w);
+            removeWindowFromVectorSafe(w);
 
             Debug::log(LOG, "Cleanup: destroyed a window");
             return;