fix unicode search

hypothesis · Nov 9, 2016 · ad0d805 · ad0d805
1 parent 374bfbb
commit ad0d805
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/h/static/scripts/controllers/search-bar-controller.js b/h/static/scripts/controllers/search-bar-controller.js
@@ -200,7 +200,7 @@ class SearchBarController extends Controller {
         let inputFilter = stringUtil.fold(stringUtil.normalize(currentInput));
 
         if(typeFilter === TAG_TYPE){
-          inputFilter = currentInput.substr(/*'tag:' len*/4);
+          inputFilter = inputFilter.substr(/*'tag:' len*/4);
 
           // remove the initial quote for comparisons if it exists
           if(inputFilter[0] === '\'' || inputFilter[0] === '"'){

diff --git a/h/static/scripts/tests/controllers/search-bar-controller-test.js b/h/static/scripts/tests/controllers/search-bar-controller-test.js
@@ -81,6 +81,10 @@ describe('SearchBarController', function () {
           tag: 'multi word',
           count: 1,
         },
+        {
+          tag: 'effort',
+          count: 1,
+        },
       ];
 
       let tagsScript = document.createElement('script');
@@ -188,6 +192,15 @@ describe('SearchBarController', function () {
           });
       });
 
+      it('handles filtering matches with unicode', function(done){
+        syn
+          .click(input)
+          .type('tag:éf', () => {
+            assert.deepEqual(getItemTitles(), [ 'effort' ], 'matches éffort with unicode value');
+            done();
+          });
+      });
+
     });
   });
 

diff --git a/h/static/scripts/util/string.js b/h/static/scripts/util/string.js
@@ -37,6 +37,7 @@ function normalize(str){
   // that is loaded globally on the running webpage
   // not a require in the node context
   try{
+    // polyfill String.prototype.normalize
     require('unorm');
   }catch(e){
     console.error('unorm not available');