Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added scroll strategy for overlay #2601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aneeshsharma
Copy link
Contributor

Description

Added scrollStrategy to overlay to reposition the overlay while scrolling. This makes the overlay stick to the position on the page and scrolls along with the rest of the page.

This would only work if the cdk-scrollable directive is used on the container that is being scrolled through.

So, its not a universal solution, but cdk-scrollable needs to be added to any containers that have overlays that are facing this issue.

@aneeshsharma aneeshsharma requested a review from a team as a code owner January 3, 2024 09:48
@aneeshsharma
Copy link
Contributor Author

For reference, this is where I found the solution.

angular/components#6157 (comment)

angular/components#6157

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7080b66) 81.71% compared to head (33287f7) 81.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2601   +/-   ##
=======================================
  Coverage   81.71%   81.71%           
=======================================
  Files         928      928           
  Lines       20794    20795    +1     
  Branches     3137     3137           
=======================================
+ Hits        16991    16992    +1     
  Misses       3662     3662           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 3, 2024

Test Results

    4 files  ±0    316 suites  ±0   32m 45s ⏱️ -8s
1 136 tests ±0  1 136 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 146 runs  ±0  1 146 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 33287f7. ± Comparison against base commit 7080b66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants