Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance string array cell renderer to support view modes #2587

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

arjunlalb
Copy link
Contributor

Description

With the new addition of options in column config, now we can customize cell renderers using inputs.
Using this to enhance the rendering options available in string array cell renderer.

Testing

Verified manually. Added UTs.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner December 21, 2023 05:50
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ab4038) 81.69% compared to head (805631c) 81.69%.
Report is 1 commits behind head on main.

❗ Current head 805631c differs from pull request most recent head be95e28. Consider uploading reports for the commit be95e28 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2587   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         928      928           
  Lines       20788    20791    +3     
  Branches     3135     3136    +1     
=======================================
+ Hits        16982    16985    +3     
  Misses       3665     3665           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

       4 files     316 suites   32m 41s ⏱️
1 136 tests 1 136 ✔️ 0 💤 0
1 146 runs  1 146 ✔️ 0 💤 0

Results for commit 805631c.

@arjunlalb arjunlalb enabled auto-merge (squash) December 21, 2023 06:02
@arjunlalb arjunlalb merged commit 9b7e655 into main Dec 21, 2023
10 checks passed
@arjunlalb arjunlalb deleted the enhance-string-array-cell-renderer branch December 21, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants