Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable search history by default for Search Box #2566

Merged
merged 13 commits into from
Jan 4, 2024

Conversation

aneeshsharma
Copy link
Contributor

Description

  • Set default value for enableSearchHistory to true in ht-search-box
  • Added debounce time to the search history values being emitted. This is done to prevent search history storing all iterations of a word when typing if the debounce time is set to 0.
  • Fixed duplicate values in search history

Copy link

github-actions bot commented Dec 7, 2023

Test Results

       4 files  ±0     316 suites  ±0   32m 32s ⏱️ +21s
1 137 tests +2  1 137 ✔️ +2  0 💤 ±0  0 ±0 
1 147 runs  +2  1 147 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 30e5c2a. ± Comparison against base commit 667ff6e.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9db405) 81.74% compared to head (30e5c2a) 81.69%.

❗ Current head 30e5c2a differs from pull request most recent head 1a3d1d6. Consider uploading reports for the commit 1a3d1d6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2566      +/-   ##
==========================================
- Coverage   81.74%   81.69%   -0.05%     
==========================================
  Files         929      928       -1     
  Lines       20845    20797      -48     
  Branches     3145     3142       -3     
==========================================
- Hits        17039    16991      -48     
  Misses       3665     3665              
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aneeshsharma aneeshsharma marked this pull request as ready for review December 11, 2023 07:14
@aneeshsharma aneeshsharma requested a review from a team as a code owner December 11, 2023 07:14
@aneeshsharma aneeshsharma enabled auto-merge (squash) January 4, 2024 11:12
@aneeshsharma aneeshsharma merged commit cf7c36a into main Jan 4, 2024
10 checks passed
@aneeshsharma aneeshsharma deleted the fix-search-box-history-default branch January 4, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants