Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow splitter overflow #2430

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: disallow splitter overflow #2430

merged 1 commit into from
Sep 25, 2023

Conversation

jake-bassett
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@jake-bassett jake-bassett requested a review from a team as a code owner September 25, 2023 22:03
@jake-bassett jake-bassett enabled auto-merge (squash) September 25, 2023 22:07
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2430 (6d1f6fa) into main (967e0b8) will decrease coverage by 30.23%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2430       +/-   ##
===========================================
- Coverage   82.98%   52.76%   -30.23%     
===========================================
  Files         921      921               
  Lines       20558    20558               
  Branches     3245     3245               
===========================================
- Hits        17061    10847     -6214     
- Misses       3375     9286     +5911     
- Partials      122      425      +303     

see 300 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jake-bassett jake-bassett merged commit 6778bc0 into main Sep 25, 2023
@jake-bassett jake-bassett deleted the fix-splitter-overflow branch September 25, 2023 22:13
@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

       4 files     310 suites   45m 26s ⏱️
1 126 tests 1 126 ✔️ 0 💤 0 ❌
1 136 runs  1 136 ✔️ 0 💤 0 ❌

Results for commit 6778bc0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants