feat(load-async): add typing #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2418 +/- ##
==========================================
- Coverage 82.83% 80.91% -1.93%
==========================================
Files 921 921
Lines 20547 20549 +2
Branches 3241 3241
==========================================
- Hits 17020 16627 -393
- Misses 3402 3786 +384
- Partials 125 136 +11
... and 73 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
| @@ -59,8 +59,8 @@ export const ASYNC_WRAPPER_PARAMETERS$ = new InjectionToken<Observable<LoadAsync | |||
| styleUrls: ['./load-async-wrapper.scss'], | |||
| changeDetection: ChangeDetectionStrategy.OnPush | |||
| }) | |||
| export class LoadAsyncWrapperComponent { | |||
| public readonly state$: Observable<AsyncState>; | |||
| export class LoadAsyncWrapperComponent<T = any> { | |||
There was a problem hiding this comment.
Suggested change
| export class LoadAsyncWrapperComponent<T = any> { | |
| export class LoadAsyncWrapperComponent<T = unknown> { |
Any reason to use any here?
There was a problem hiding this comment.
Nope. Missed updating it.
Updated ✅
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Sep 21, 2023
This comment has been minimized.
This comment has been minimized.
arjunlalb
approved these changes
Sep 21, 2023
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add strong typing support for
*htLoadAsyncdirective.