feat: handle empty string in displaystring pipe #2413
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
- Coverage 82.87% 79.62% -3.25%
==========================================
Files 921 921
Lines 20543 20544 +1
Branches 3239 3240 +1
==========================================
- Hits 17024 16358 -666
- Misses 3394 4043 +649
- Partials 125 143 +18
... and 90 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Unit Test Results 4 files ±0 310 suites ±0 47m 13s ⏱️ + 3m 32s For more details on these failures, see this check. Results for commit eca3b49. ± Comparison against base commit aed7549. |
| @@ -13,7 +15,7 @@ export const displayString = (provided?: unknown, defaultValueOnEmpty: string = | |||
| case 'function': | |||
| return 'Function'; | |||
| case 'string': | |||
| return provided; | |||
| return !isEmpty(provided.trim()) ? provided : defaultValueOnEmpty; | |||
There was a problem hiding this comment.
Do we know every place we use this pipe we want to treat empty string as undefined? Most places this is probably safe, but this seems like a risky change especially for something that feels like a caller bug.
No description provided.