-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: table component should emit column change when columns are updated #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandtiwary
previously approved these changes
Sep 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #2399 +/- ##
===========================================
+ Coverage 52.62% 82.93% +30.30%
===========================================
Files 920 920
Lines 20490 20493 +3
Branches 3223 3223
===========================================
+ Hits 10783 16995 +6212
+ Misses 9281 3376 -5905
+ Partials 426 122 -304
... and 300 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
jake-bassett
previously approved these changes
Sep 14, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…-ui into column-change-emit
arjunlalb
dismissed stale reviews from jake-bassett and anandtiwary
via
September 14, 2023 23:59
569df9e
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Table component should emit the column list whenever its updated.
Testing
Manual testing done.
Checklist: