Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table component should emit column change when columns are updated #2399

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

arjunlalb
Copy link
Contributor

Description

Table component should emit the column list whenever its updated.

Testing

Manual testing done.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner September 14, 2023 23:42
anandtiwary
anandtiwary previously approved these changes Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2399 (6cf723a) into main (ca2a8f9) will increase coverage by 30.30%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #2399       +/-   ##
===========================================
+ Coverage   52.62%   82.93%   +30.30%     
===========================================
  Files         920      920               
  Lines       20490    20493        +3     
  Branches     3223     3223               
===========================================
+ Hits        10783    16995     +6212     
+ Misses       9281     3376     -5905     
+ Partials      426      122      -304     
Files Changed Coverage Δ
projects/components/src/table/table.component.ts 78.08% <100.00%> (+24.28%) ⬆️

... and 300 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

jake-bassett
jake-bassett previously approved these changes Sep 14, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb dismissed stale reviews from jake-bassett and anandtiwary via 569df9e September 14, 2023 23:59
@arjunlalb arjunlalb enabled auto-merge (squash) September 15, 2023 00:03
@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 80619ef into main Sep 15, 2023
14 checks passed
@arjunlalb arjunlalb deleted the column-change-emit branch September 15, 2023 00:11
@github-actions
Copy link

Unit Test Results

       4 files  ±0     309 suites  ±0   46m 24s ⏱️ -49s
1 121 tests +1  1 121 ✔️ +1  0 💤 ±0  0 ❌ ±0 
1 131 runs  +1  1 131 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 80619ef. ± Comparison against base commit ca2a8f9.

arjunlalb added a commit that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants