Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: splitter max height #2398

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: splitter max height #2398

merged 2 commits into from
Sep 15, 2023

Conversation

jake-bassett
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@jake-bassett jake-bassett requested a review from a team as a code owner September 14, 2023 23:29
@jake-bassett jake-bassett enabled auto-merge (squash) September 14, 2023 23:29
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2398 (cd120b1) into main (977f1c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2398   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         920      920           
  Lines       20489    20490    +1     
  Branches     3222     3223    +1     
=======================================
+ Hits        16970    16971    +1     
  Misses       3394     3394           
  Partials      125      125           
Files Changed Coverage Δ
...ects/components/src/splitter/splitter.component.ts 94.00% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

       4 files  ±0     309 suites  ±0   48m 56s ⏱️ + 8m 40s
1 120 tests ±0  1 120 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 130 runs  ±0  1 130 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cd120b1. ± Comparison against base commit 977f1c8.

@jake-bassett jake-bassett merged commit ca2a8f9 into main Sep 15, 2023
@jake-bassett jake-bassett deleted the fix-splitter-height-issue branch September 15, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants