Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add widget icons #2397

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat: add widget icons #2397

merged 1 commit into from
Sep 14, 2023

Conversation

jake-bassett
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@jake-bassett jake-bassett requested a review from a team as a code owner September 14, 2023 22:17
@jake-bassett jake-bassett enabled auto-merge (squash) September 14, 2023 22:20
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2397 (0bd0f76) into main (a8fc0ec) will decrease coverage by 25.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2397       +/-   ##
===========================================
- Coverage   82.82%   57.01%   -25.82%     
===========================================
  Files         920      920               
  Lines       20489    20489               
  Branches     3222     3222               
===========================================
- Hits        16970    11681     -5289     
- Misses       3394     8418     +5024     
- Partials      125      390      +265     

see 212 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jake-bassett jake-bassett merged commit 977f1c8 into main Sep 14, 2023
11 of 12 checks passed
@jake-bassett jake-bassett deleted the widget-icons branch September 14, 2023 22:27
@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

       4 files  ±0     309 suites  ±0   40m 16s ⏱️ - 4m 15s
1 120 tests ±0  1 120 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 130 runs  ±0  1 130 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 977f1c8. ± Comparison against base commit a8fc0ec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants