Splitter fixes #2396
Merged
Splitter fixes #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2396 +/- ##
==========================================
+ Coverage 82.73% 82.82% +0.09%
==========================================
Files 920 920
Lines 20510 20489 -21
Branches 3234 3222 -12
==========================================
+ Hits 16968 16970 +2
+ Misses 3413 3394 -19
+ Partials 129 125 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
palbizu
reviewed
Sep 14, 2023
| @@ -57,7 +57,7 @@ export class SplitterComponent implements OnChanges, AfterContentInit { | |||
| public readonly direction?: SplitterDirection = SplitterDirection.Horizontal; | |||
|
|
|||
| @Input() | |||
| public readonly debounceTime: number = 20; | |||
| public readonly debounceTime: number = 12; | |||
There was a problem hiding this comment.
We just needed a small number but not too small. I played with it a bit and this seemed to work well. It could be any number in that vicinity really.
| size: this.getElementSize(element) | ||
| }; | ||
| if (!this.mouseUpListener) { | ||
| this.mouseUpListener = this.renderer.listen(this.document, 'mouseup', event => { |
There was a problem hiding this comment.
question, this works like an eventListener?
| private normalizeContentDimension(content: SplitterContentDirective): SplitterContentDirective { | ||
| if (content.dimension.unit === 'FR') { | ||
| content.dimension = { | ||
| unit: 'PX', |
There was a problem hiding this comment.
could you use an Enum instead of a string for PX and FR?
There was a problem hiding this comment.
Yeah, we could. I could have created one, but just left it as a string since that's what it was originally.
palbizu
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.