refactor: increasing the width of topology tooltip #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palbizu
approved these changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 920 920
Lines 20510 20510
Branches 3234 3234
=======================================
Hits 16968 16968
Misses 3413 3413
Partials 129 129 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
Sep 13, 2023
| @@ -7,7 +7,7 @@ | |||
| opacity: 0.92; | |||
| box-shadow: 0px 4px 5px rgba(0, 0, 0, 0.2), 0px 3px 14px rgba(0, 0, 0, 0.12), 0px 8px 10px rgba(0, 0, 0, 0.14); | |||
| border-radius: 4px; | |||
| max-width: 400px; | |||
| max-width: 800px; | |||
There was a problem hiding this comment.
should we do this or wrap the text below instead of the ellipsis?
There was a problem hiding this comment.
this is fine :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 4 files 309 suites 45m 26s ⏱️ Results for commit eae893f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
refactor: increasing the width of topology tooltip
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.