feat: hold traces tooltip on hover #2387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
- Coverage 82.99% 82.98% -0.01%
==========================================
Files 921 921
Lines 20566 20570 +4
Branches 3245 3247 +2
==========================================
+ Hits 17069 17071 +2
- Misses 3375 3377 +2
Partials 122 122
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Sep 12, 2023
| this.hideCrosshair(); | ||
| this.tooltip?.hovered$ | ||
| .pipe( | ||
| debounceTime(300), |
There was a problem hiding this comment.
Why do we need the debounceTime?
There was a problem hiding this comment.
Added to provide a better user experience when hover over the graph with the cursor
anandtiwary
reviewed
Sep 12, 2023
| @@ -30,8 +33,8 @@ export class ChartTooltipPopover<TData, TContext> implements ChartTooltipRef<TDa | |||
| this.popoverRef.updatePositionStrategy({ | |||
| type: PopoverPositionType.FollowMouse, | |||
| boundingElement: element, | |||
| offsetX: 20, | |||
| offsetY: 30 | |||
| offsetX: 0, | |||
There was a problem hiding this comment.
What would be the impact of this change at other places?
There was a problem hiding this comment.
will be changing the way that we display the tooltip keeping it visible when the user has the cursor on the tooltip but will not break the functionality.
added 4 commits
September 14, 2023 19:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hold tooltip on hover
Testing
Locally tested
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.