Skip to content

Commit

Permalink
fix: minor updates to explorer field accessors
Browse files Browse the repository at this point in the history
  • Loading branch information
23nobody committed Sep 20, 2023
1 parent 91df8fe commit 95c7e99
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions projects/observability/src/pages/explorer/explorer.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import { Filter, FilterAttribute, ToggleItem } from '@hypertrace/components';
import { isEmpty, isNil } from 'lodash-es';
import { concat, EMPTY, Observable, Subject } from 'rxjs';
import { map, take } from 'rxjs/operators';
import { map } from 'rxjs/operators';
import { CartesianSeriesVisualizationType } from '../../shared/components/cartesian/chart';
import {
ExploreOrderBy,
Expand Down Expand Up @@ -156,7 +156,7 @@ export class ExplorerComponent {

public constructor(
private readonly metadataService: MetadataService,
private readonly navigationService: NavigationService,
protected readonly navigationService: NavigationService,
private readonly timeDurationService: TimeDurationService,
private readonly preferenceService: PreferenceService,
@Inject(EXPLORER_DASHBOARD_BUILDER_FACTORY) explorerDashboardBuilderFactory: ExplorerDashboardBuilderFactory,
Expand All @@ -167,10 +167,7 @@ export class ExplorerComponent {
this.resultsExpanded$ = this.preferenceService.get(ExplorerComponent.RESULTS_EXPANDED_PREFERENCE, true);
this.resultsDashboard$ = this.explorerDashboardBuilder.resultsDashboard$;
this.vizDashboard$ = this.explorerDashboardBuilder.visualizationDashboard$;
this.initialState$ = activatedRoute.queryParamMap.pipe(
take(1),
map(paramMap => this.mapToInitialState(paramMap))
);
this.initialState$ = activatedRoute.queryParamMap.pipe(map(paramMap => this.mapToInitialState(paramMap)));
this.currentContext$ = concat(
this.initialState$.pipe(map(value => value.contextToggle.value.dashboardContext)),
this.contextChangeSubject
Expand Down Expand Up @@ -398,12 +395,13 @@ export const enum ScopeQueryParam {
EndpointTraces = 'endpoint-traces',
Spans = 'spans'
}
const enum ExplorerQueryParam {
export const enum ExplorerQueryParam {
Scope = 'scope',
Interval = 'interval',
Group = 'group',
OtherGroup = 'other',
GroupLimit = 'limit',
Series = 'series',
Order = 'order'
Order = 'order',
Filter = 'filter'
}

0 comments on commit 95c7e99

Please sign in to comment.