Skip to content

Commit

Permalink
Upgrade to v14 (#2105)
Browse files Browse the repository at this point in the history
* feat: upgrading to ng 13

* feat: adding eslint

* refactor: upgrade jest

* refactor: updating package lock

* refactor: updating test path pattern option

* refactor: fix test error

* refactor: address review comments

* refactor: import ApolloModule
  • Loading branch information
anandtiwary authored Apr 6, 2023
1 parent ddccf82 commit 69e7af1
Show file tree
Hide file tree
Showing 215 changed files with 18,804 additions and 43,959 deletions.
281 changes: 281 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,281 @@
{
"root": true,
"ignorePatterns": [
"**/*.js"
],
"overrides": [
{
"files": [
"*.ts"
],
"parserOptions": {
"project": [
"tsconfig.json",
"tsconfig.app.json"
],
"createDefaultProgram": true
},
"extends": [
"plugin:@angular-eslint/ng-cli-compat",
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
"plugin:@angular-eslint/template/process-inline-templates",
"plugin:@typescript-eslint/all",
"prettier"
],
"plugins": ["eslint-plugin-no-null", "eslint-plugin-unicorn"],
"rules": {
"@angular-eslint/component-max-inline-declarations": [
"error",
{
"template": 120
}
],
"@angular-eslint/component-selector": [
"error",
{
"type": "element",
"prefix": "ht",
"style": "kebab-case"
}
],
"@angular-eslint/directive-selector": [
"error",
{
"type": "attribute",
"prefix": "ht",
"style": "camelCase"
}
],
"@angular-eslint/no-attribute-decorator": "error",
"@angular-eslint/no-forward-ref": "error",
"@angular-eslint/no-lifecycle-call": "error",
"@angular-eslint/no-pipe-impure": "error",
"@angular-eslint/no-queries-metadata-property": "error",
"@angular-eslint/prefer-on-push-component-change-detection": "error",
"@angular-eslint/prefer-output-readonly": "error",
"@angular-eslint/use-component-view-encapsulation": "error",
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/ban-ts-comment": "error",
"@typescript-eslint/consistent-type-definitions": "error",
"@typescript-eslint/explicit-member-accessibility": [
"error",
{
"accessibility": "explicit",
"overrides": {
"accessors": "explicit",
"constructors": "explicit",
"parameterProperties": "explicit"
}
}
],
"@typescript-eslint/member-delimiter-style": [
"off",
{
"multiline": {
"delimiter": "none",
"requireLast": true
},
"singleline": {
"delimiter": "semi",
"requireLast": false
}
}
],
"@typescript-eslint/no-empty-function": "error",
"@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/no-for-in-array": "error",
"@typescript-eslint/no-require-imports": "error",
"@typescript-eslint/no-this-alias": "error",
"@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
"@typescript-eslint/no-unnecessary-qualifier": "error",
"@typescript-eslint/no-unnecessary-type-arguments": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
"@typescript-eslint/no-var-requires": "error",
"@typescript-eslint/prefer-readonly": "error",
"@typescript-eslint/quotes": [
"off",
"single",
{
"allowTemplateLiterals": true
}
],
"@typescript-eslint/require-await": "error",
"@typescript-eslint/restrict-plus-operands": "error",
"arrow-body-style": ["error", "as-needed"],
"complexity": ["error", 20],
"default-case": "error",
"eqeqeq": [
"error",
"always"
],
"import/no-default-export": "error",
"import/no-internal-modules": "off",
"import/no-unassigned-import": "error",
"max-classes-per-file": [
"error",
1
],
"max-lines": [
"error",
500
],
"no-duplicate-case": "error",
"no-duplicate-imports": "error",
"no-empty": "error",
"no-extra-bind": "error",
"no-new-func": "error",
"no-param-reassign": "error",
"no-redeclare": "error",
"no-restricted-syntax": [
"error",
"ForInStatement"
],
"no-return-await": "error",
"no-sequences": "error",
"no-sparse-arrays": "error",
"no-void": "error",
"object-shorthand": [
"error",
"never"
],
"padding-line-between-statements": [
"error",
{
"blankLine": "always",
"prev": "*",
"next": "return"
}
],
"prefer-object-spread": "error",
"prefer-template": "error",
"quote-props": "off",
"radix": "off",
"react/jsx-curly-spacing": "off",
"react/jsx-equals-spacing": "off",
"react/jsx-tag-spacing": [
"off",
{
"afterOpening": "allow",
"closingSlash": "allow"
}
],
"react/jsx-wrap-multilines": "off",
"space-before-function-paren": "off",
"space-in-parens": [
"off",
"never"
],
"unicorn/filename-case": "error",
"yoda": "off",
"@typescript-eslint/prefer-string-starts-ends-with": "off",
"@typescript-eslint/object-curly-spacing": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-call": "off",
"@typescript-eslint/consistent-indexed-obj": "off",
"no-template-curly-in-string": "off",
"@typescript-eslint/naming-convention": "off",
"no-null/no-null": "off",
"no-useless-constructor": "off",
"no-underscore-dangle": "off",
"jsdoc/newline-after-description": "off",
"@typescript-eslint/array-type": "off",
"@typescript-eslint/prefer-regexp-exec": "off",
"@typescript-eslint/parameter-properties": "off",
"@typescript-eslint/consistent-type-exports": "off",
"@typescript-eslint/no-redundant-type-constituents":"off",
"@typescript-eslint/promise-function-async": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"@typescript-eslint/no-confusing-void-expression": "off",
"@typescript-eslint/consistent-generic-constructors": "off",
"@typescript-eslint/consistent-indexed-object-style": "off",
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/sort-type-constituents": "off",
"prefer-const": "off",
"import/no-extraneous-dependencies": "off",
"@typescript-eslint/prefer-nullish-coalescing": "off",
"prefer-arrow/prefer-arrow-functions": "off",
"@typescript-eslint/method-signature-style": "off",
"@typescript-eslint/no-unnecessary-type-constraint": "off",
"capitalized-comments": "off",
"@typescript-eslint/consistent-type-imports": "off",
"@typescript-eslint/no-type-alias": "off",
"@typescript-eslint/prefer-readonly-parameter-types": "off",
"@typescript-eslint/no-magic-numbers": "off",
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/member-ordering": "off",
"@typescript-eslint/no-extraneous-class": "off",
"@typescript-eslint/no-floating-promises": "off",
"@typescript-eslint/strict-boolean-expressions": "off",
"@typescript-eslint/no-unsafe-return": "off",
"@typescript-eslint/no-non-null-asserted-optional-chain": "off",
"@typescript-eslint/no-unsafe-argument": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/semi": ["off", null],
"@typescript-eslint/type-annotation-spacing": "off",
"@typescript-eslint/unbound-method": "off",
"@typescript-eslint/init-declarations": "off",
"@typescript-eslint/lines-between-class-members": "off",
"@typescript-eslint/explicit-module-boundary-types": "off",
"@typescript-eslint/prefer-optional-chain": "off",
"@typescript-eslint/prefer-enum-initializers": "off",
"@typescript-eslint/non-nullable-type-assertion-style": "off",
"@typescript-eslint/no-unnecessary-condition": "off",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-empty-interface": "off",
"@typescript-eslint/no-redundant-type-cons": "off",
"@typescript-eslint/ban-types": "off",
"@typescript-eslint/no-unused-expressions": "off",
"@typescript-eslint/no-inferrable-types": "off",
"prefer-spread": "off",
"no-unnecessary-class": "off",
"import/order": "off",
"id-blacklist": "off",
"init-declarations": "off",
"arrow-parens": ["off", "always"],
"brace-style": ["off", "off"],
"class-methods-use-this": "off",
"eol-last": "off",
"import/no-deprecated": "off",
"linebreak-style": "off",
"max-len": "off",
"new-parens": "off",
"newline-per-chained-call": "off",
"no-extra-semi": "off",
"no-irregular-whitespace": "off",
"no-magic-numbers": "off",
"no-plusplus": [
"off",
{
"allowForLoopAfterthoughts": true
}
],
"no-trailing-spaces": "off"
}
},
{
"files": [
"*.html"
],
"extends": [
"plugin:@angular-eslint/template/recommended"
],
"rules": {
"@angular-eslint/template/no-negated-async": "off",
"@angular-eslint/template/conditional-complexity": [
"error",
{
"maxComplexity": 4
}
],
"@angular-eslint/template/cyclomatic-complexity": [
"error",
{
"maxComplexity": 15
}
],
"@angular-eslint/template/use-track-by-function": "off"
}
}
]
}
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
key: ${{ runner.os }}-node-modules-${{ hashFiles('package-lock.json') }}

- name: Test
run: npm run test:ci -- $(echo $CHUNKS | jq -r '.[${{ matrix.chunk }}] | .[] | "--testPathPattern "+.')
run: npm run test:ci -- $(echo $CHUNKS | jq -r '.[${{ matrix.chunk }}] | .[] | "--test-path-pattern "+.')
env:
CHUNKS: ${{ needs['setup-test-batches'].outputs['test-chunks'] }}

Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ build
!.vscode/extensions.json

# misc
/.angular/cache
/.sass-cache
/connect.lock
/coverage
Expand Down
Loading

0 comments on commit 69e7af1

Please sign in to comment.