Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore | Add SpanJoiner based on list of spanId #177

Merged
merged 7 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import com.google.inject.multibindings.Multibinder;
import org.hypertrace.core.graphql.common.request.ResultSetRequestBuilder;
import org.hypertrace.core.graphql.span.dao.SpanDaoModule;
import org.hypertrace.core.graphql.span.joiner.SpanJoinerModule;
import org.hypertrace.core.graphql.span.joiner.JoinerModule;
import org.hypertrace.core.graphql.span.request.SpanRequestModule;
import org.hypertrace.core.graphql.spi.schema.GraphQlSchemaFragment;

Expand All @@ -18,6 +18,6 @@ protected void configure() {
requireBinding(ResultSetRequestBuilder.class);
install(new SpanDaoModule());
install(new SpanRequestModule());
install(new SpanJoinerModule());
install(new JoinerModule());
}
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@
import org.hypertrace.core.graphql.common.request.FilterRequestBuilder;
import org.hypertrace.core.graphql.common.request.ResultSetRequestBuilder;
import org.hypertrace.core.graphql.span.dao.SpanDao;
import org.hypertrace.core.graphql.span.joiner.multiple.span.DefaultMultipleSpanJoinerBuilder;
import org.hypertrace.core.graphql.span.joiner.multiple.span.MultipleSpanJoinerBuilder;
import org.hypertrace.core.graphql.span.joiner.single.span.DefaultSpanJoinerBuilder;
import org.hypertrace.core.graphql.span.joiner.single.span.SpanJoinerBuilder;
import org.hypertrace.core.graphql.utils.schema.GraphQlSelectionFinder;

public class SpanJoinerModule extends AbstractModule {
public class JoinerModule extends AbstractModule {

@Override
protected void configure() {
bind(SpanJoinerBuilder.class).to(DefaultSpanJoinerBuilder.class);
bind(MultipleSpanJoinerBuilder.class).to(DefaultMultipleSpanJoinerBuilder.class);

requireBinding(SpanDao.class);
requireBinding(GraphQlSelectionFinder.class);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
package org.hypertrace.core.graphql.span.joiner;

import static org.hypertrace.core.graphql.atttributes.scopes.HypertraceCoreAttributeScopeString.SPAN;

import com.google.common.collect.ArrayListMultimap;
import com.google.common.collect.ListMultimap;
import com.google.common.collect.Multimaps;
import com.google.inject.Inject;
import graphql.schema.SelectedField;
import io.reactivex.rxjava3.core.Single;
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Optional;
import java.util.Set;
import java.util.function.Function;
import java.util.stream.Collectors;
import lombok.AllArgsConstructor;
import lombok.Value;
import lombok.experimental.Accessors;
import org.hypertrace.core.graphql.common.request.AttributeAssociation;
import org.hypertrace.core.graphql.common.request.AttributeRequest;
import org.hypertrace.core.graphql.common.request.FilterRequestBuilder;
import org.hypertrace.core.graphql.common.request.ResultSetRequest;
import org.hypertrace.core.graphql.common.request.ResultSetRequestBuilder;
import org.hypertrace.core.graphql.common.schema.arguments.TimeRangeArgument;
import org.hypertrace.core.graphql.common.schema.attributes.AttributeScope;
import org.hypertrace.core.graphql.common.schema.attributes.arguments.AttributeExpression;
import org.hypertrace.core.graphql.common.schema.id.Identifiable;
import org.hypertrace.core.graphql.common.schema.results.arguments.filter.FilterArgument;
import org.hypertrace.core.graphql.common.schema.results.arguments.filter.FilterOperatorType;
import org.hypertrace.core.graphql.common.schema.results.arguments.filter.FilterType;
import org.hypertrace.core.graphql.common.schema.results.arguments.order.OrderArgument;
import org.hypertrace.core.graphql.context.GraphQlRequestContext;
import org.hypertrace.core.graphql.span.dao.SpanDao;
import org.hypertrace.core.graphql.span.request.SpanRequest;
import org.hypertrace.core.graphql.span.schema.Span;
import org.hypertrace.core.graphql.span.schema.SpanResultSet;

@AllArgsConstructor(onConstructor_ = {@Inject})
public class SourceToSpansProvider {

private static final int ZERO_OFFSET = 0;

private final SpanDao spanDao;
private final ResultSetRequestBuilder resultSetRequestBuilder;
private final FilterRequestBuilder filterRequestBuilder;

public <T> Single<ListMultimap<T, Span>> joinSpans(
GraphQlRequestContext context,
TimeRangeArgument timeRange,
List<SelectedField> selectedFields,
Map<T, List<String>> sourceToSpanIdsMap) {
return this.buildSpanRequest(context, timeRange, selectedFields, sourceToSpanIdsMap)
.flatMap(spanDao::getSpans)
.map(this::buildSpanIdToSpanMap)
.map(spanIdToSpanMap -> buildSourceToSpanListMultiMap(sourceToSpanIdsMap, spanIdToSpanMap));
}

private <T> ListMultimap<T, Span> buildSourceToSpanListMultiMap(
Map<T, List<String>> sourceToSpanIdsMap, Map<String, Span> spanIdToSpanMap) {
ListMultimap<T, Span> listMultimap = ArrayListMultimap.create();
for (Entry<T, List<String>> entry : sourceToSpanIdsMap.entrySet()) {
T source = entry.getKey();
for (String spanId : entry.getValue()) {
if (spanIdToSpanMap.containsKey(spanId)) {
listMultimap.put(source, spanIdToSpanMap.get(spanId));
}
}
}
return Multimaps.unmodifiableListMultimap(listMultimap);
}

private Map<String, Span> buildSpanIdToSpanMap(SpanResultSet resultSet) {
return resultSet.results().stream()
.collect(Collectors.toUnmodifiableMap(Identifiable::id, Function.identity()));
}

private <T> Single<SpanRequest> buildSpanRequest(
GraphQlRequestContext context,
TimeRangeArgument timeRange,
List<SelectedField> selectedFields,
Map<T, List<String>> sourceToSpanIdsMap) {
Collection<String> spanIds =
sourceToSpanIdsMap.values().stream()
.flatMap(List::stream)
.distinct()
.collect(Collectors.toUnmodifiableList());
return buildSpanIdsFilter(context, spanIds)
.flatMap(
filterArguments ->
buildSpanRequest(
spanIds.size(), context, timeRange, selectedFields, filterArguments));
}

private Single<SpanRequest> buildSpanRequest(
int size,
GraphQlRequestContext context,
TimeRangeArgument timeRange,
List<SelectedField> selectedFields,
List<AttributeAssociation<FilterArgument>> filterArguments) {
return resultSetRequestBuilder
.build(
context,
SPAN,
size,
ZERO_OFFSET,
timeRange,
Collections.emptyList(),
filterArguments,
selectedFields.stream(),
Optional.empty())
.map(spanEventsRequest -> new SpanJoinRequest(context, spanEventsRequest));
}

private Single<List<AttributeAssociation<FilterArgument>>> buildSpanIdsFilter(
GraphQlRequestContext context, Collection<String> spanIds) {
return filterRequestBuilder.build(context, SPAN, Set.of(new SpanIdFilter(spanIds)));
}

@Value
@Accessors(fluent = true)
private static class SpanIdFilter implements FilterArgument {
FilterType type = FilterType.ID;
String key = null;
AttributeExpression keyExpression = null;
FilterOperatorType operator = FilterOperatorType.IN;
Collection<String> value;
AttributeScope idType = null;
String idScope = SPAN;
}

@Value
@Accessors(fluent = true)
private static class SpanJoinRequest implements SpanRequest {
GraphQlRequestContext context;
ResultSetRequest<OrderArgument> spanEventsRequest;
Collection<AttributeRequest> logEventAttributes = Collections.emptyList();
boolean fetchTotal = false;
}
}
Loading
Loading