chore: add support to disable introspection #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
============================================
+ Coverage 57.44% 57.79% +0.34%
- Complexity 265 268 +3
============================================
Files 92 92
Lines 1464 1476 +12
Branches 42 42
============================================
+ Hits 841 853 +12
Misses 593 593
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tim-mwangi
reviewed
Apr 5, 2024
| org.reactivestreams:reactive-streams:1.0.3=compileClasspath | ||
| org.reactivestreams:reactive-streams:1.0.4=runtimeClasspath | ||
| org.slf4j:slf4j-api:2.0.7=compileClasspath,runtimeClasspath | ||
| empty=annotationProcessor | ||
| empty= |
There was a problem hiding this comment.
Yep. Previously it had that to say there were no annotation processor dependencies, but that it was locked. Now the annotation processor includes lombok above.
tim-mwangi
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a config to disable introspection. Refactored config to separate the generic server config (a single graphql service JVM can run multiple servers) from the service-specific config.