Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fetch attribute by id in Attribute Store #171

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

anujgoyal1
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Added ability to fetch on attribute id.

@anujgoyal1 anujgoyal1 requested a review from a team as a code owner March 27, 2024 08:54
Copy link

github-actions bot commented Mar 27, 2024

Test Results

110 tests  ±0   110 ✅ ±0   56s ⏱️ -1s
 38 suites ±0     0 💤 ±0 
 38 files   ±0     0 ❌ ±0 

Results for commit e191c2f. ± Comparison against base commit 4420bc3.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.44%. Comparing base (4420bc3) to head (e191c2f).

Files Patch % Lines
...core/graphql/attributes/CachingAttributeStore.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #171      +/-   ##
============================================
- Coverage     57.72%   57.44%   -0.28%     
  Complexity      265      265              
============================================
  Files            92       92              
  Lines          1457     1464       +7     
  Branches         42       42              
============================================
  Hits            841      841              
- Misses          586      593       +7     
  Partials         30       30              
Flag Coverage Δ
unit 57.44% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anujgoyal1 anujgoyal1 merged commit de98fa8 into main Mar 27, 2024
6 of 8 checks passed
@anujgoyal1 anujgoyal1 deleted the fetchAttributeByFqn branch March 27, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants