Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logical operator in hypertrace gql common schema #165

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

bhubam
Copy link
Contributor

@bhubam bhubam commented Feb 7, 2024

Description

Added logical operator in hypertrace gql common schema

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@bhubam bhubam requested a review from a team as a code owner February 7, 2024 05:18
Copy link

github-actions bot commented Feb 7, 2024

Test Results

110 tests  ±0   110 ✅ ±0   56s ⏱️ -1s
 38 suites ±0     0 💤 ±0 
 38 files   ±0     0 ❌ ±0 

Results for commit 5e58bc6. ± Comparison against base commit dd582cd.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dd582cd) 57.84% compared to head (5e58bc6) 57.72%.

Files Patch % Lines
...raphql/common/schema/operator/LogicalOperator.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #165      +/-   ##
============================================
- Coverage     57.84%   57.72%   -0.12%     
  Complexity      265      265              
============================================
  Files            91       92       +1     
  Lines          1454     1457       +3     
  Branches         42       42              
============================================
  Hits            841      841              
- Misses          583      586       +3     
  Partials         30       30              
Flag Coverage Δ
unit 57.72% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhubam bhubam merged commit 504a2f7 into main Feb 7, 2024
6 of 8 checks passed
@bhubam bhubam deleted the add-logical-operator-in-common-schema branch February 7, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants