Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for deserializing zoned expressions #153

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Adds support for accepting zoned date time strings. Previously only accepted UTC, but could return a UTC from either zoned or UTC.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner November 30, 2023 17:18
Copy link

github-actions bot commented Nov 30, 2023

Test Results

110 tests  ±0   110 ✔️ ±0   53s ⏱️ -1s
  38 suites ±0       0 💤 ±0 
  38 files   ±0       0 ±0 

Results for commit f9399fa. ± Comparison against base commit beeb208.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd15f6e) 56.44% compared to head (f9399fa) 57.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #153      +/-   ##
============================================
+ Coverage     56.44%   57.60%   +1.16%     
- Complexity      264      265       +1     
============================================
  Files            92       91       -1     
  Lines          1474     1446      -28     
  Branches         42       42              
============================================
+ Hits            832      833       +1     
+ Misses          612      583      -29     
  Partials         30       30              
Flag Coverage Δ
unit 57.60% <100.00%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaron-steinfeld aaron-steinfeld merged commit 6b980ed into main Nov 30, 2023
8 checks passed
@aaron-steinfeld aaron-steinfeld deleted the support-reading-non-utc-instant branch November 30, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants