chore | add support for multi filter arguments #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
============================================
- Coverage 57.57% 56.44% -1.14%
Complexity 264 264
============================================
Files 91 92 +1
Lines 1445 1474 +29
Branches 42 42
============================================
Hits 832 832
- Misses 583 612 +29
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
suresh-prakash
approved these changes
Nov 27, 2023
|
|
||
| @Override | ||
| public Single<Filter> convert( | ||
| Collection<Collection<AttributeAssociation<FilterArgument>>> filters) { |
There was a problem hiding this comment.
Why are we assuming a collection of collection of filters should be an OR-AND relationship? That's extremely unintuitive. Can we revert this and instead build a real converter here that allows the caller to build relationships - (collection<filters>, logicalOperator) => filter
aman-bansal
added a commit
that referenced
this pull request
Nov 27, 2023
This reverts commit fd15f6e.
aman-bansal
added a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.