Bom #147
Merged
Bom #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=========================================
Coverage 57.57% 57.57%
Complexity 264 264
=========================================
Files 91 91
Lines 1445 1445
Branches 42 42
=========================================
Hits 832 832
Misses 583 583
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tim-mwangi
reviewed
Nov 2, 2023
| io.grpc:grpc-api:1.57.2=runtimeClasspath | ||
| io.grpc:grpc-bom:1.57.2=compileClasspath,runtimeClasspath | ||
| io.grpc:grpc-context:1.57.2=runtimeClasspath | ||
| io.grpc:grpc-core:1.57.2=runtimeClasspath |
There was a problem hiding this comment.
This could be tangential but does this grpc version have the fix for RST stream vulnerability?
There was a problem hiding this comment.
transport level concern, but netty does as of 100:
https://netty.io/news/2023/10/10/4-1-100-Final.html
we constrain to at least that version via the BOM (see
hypertrace-core-graphql-service/gradle.lockfile lines 55-66)
tim-mwangi
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate project to use common BOM