Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logical operators to filter operator type #145

Closed
wants to merge 1 commit into from

Conversation

dhruv-singhal-github
Copy link

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@dhruv-singhal-github dhruv-singhal-github requested a review from a team as a code owner September 24, 2023 21:45
@github-actions
Copy link

Test Results

110 tests  ±0   110 ✔️ ±0   39s ⏱️ -5s
  38 suites ±0       0 💤 ±0 
  38 files   ±0       0 ±0 

Results for commit a1da44b. ± Comparison against base commit ee2d2c7.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #145 (a1da44b) into main (a4e7276) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #145      +/-   ##
============================================
+ Coverage     57.57%   57.63%   +0.05%     
  Complexity      264      264              
============================================
  Files            91       91              
  Lines          1445     1447       +2     
  Branches         42       42              
============================================
+ Hits            832      834       +2     
  Misses          583      583              
  Partials         30       30              
Flag Coverage Δ
unit 57.63% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...a/results/arguments/filter/FilterOperatorType.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not supported by the basic filter types

@dhruv-singhal-github
Copy link
Author

Will create a new enum for specific operators. Closing this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants