feat: add request argument to model-api getData method (#766)

hypertrace · Dec 12, 2023 · 6e5f249 · 6e5f249
1 parent 0cfa9c3
commit 6e5f249
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/data/data-source/data-source.ts b/src/data/data-source/data-source.ts
@@ -6,11 +6,11 @@ export const dataSourceMarker = Symbol('Data Source Marker');
 /**
  * A model which can be used to retrieve data asynchronously
  */
-export interface DataSource<T> {
+export interface DataSource<T, R = unknown> {
   /**
    * Retrieves data of type T in the form of an observable
    */
-  getData(): Observable<T>;
+  getData(request?: R): Observable<T>;
 
   /**
    * A marker property used to determine if the implementing class is

diff --git a/src/model/api/default-model-api.ts b/src/model/api/default-model-api.ts
@@ -69,7 +69,7 @@ export class DefaultModelApi implements ModelApi {
   /**
    * @inheritdoc
    */
-  public getData<T>(): Observable<T> {
+  public getData<T, R>(request?: R): Observable<T> {
     const dataSource = this.dataSourceManager.getClosest<T>(this.model);
 
     if (!dataSource) {
@@ -78,7 +78,7 @@ export class DefaultModelApi implements ModelApi {
       return EMPTY;
     }
 
-    return dataSource.getData();
+    return dataSource.getData(request);
   }
 
   /**

diff --git a/src/model/api/model-api.ts b/src/model/api/model-api.ts
@@ -32,7 +32,7 @@ export interface ModelApi {
    *     attached to)
    *   - Else, recurse upwards to parent
    */
-  getData<T>(): Observable<T>;
+  getData<T, R = unknown>(request?: R): Observable<T>;
 
   /**
    * Retrieves the merged theme specified for this model