Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating filter result to add decorations #236

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

varkey98
Copy link
Contributor

@varkey98 varkey98 commented Jul 24, 2024

Description

Adding a Decoration field to FilterResult. The Decoration struct can have mutations defined on request or response objects which should be applied on a filter result match. Starting with request header injections, in which a list of headers can be specified to be injected on a filter evaluation match

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@varkey98
Copy link
Contributor Author

I've updated the 2 server instrumentations we have on goagent as well to use the updated filter result, pls let me know if we want to separate it onto a different pr

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (849c958) to head (cc405c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   59.45%   59.89%   +0.44%     
==========================================
  Files          70       70              
  Lines        2348     2364      +16     
==========================================
+ Hits         1396     1416      +20     
+ Misses        867      863       -4     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varkey98 varkey98 requested a review from tim-mwangi July 24, 2024 07:12
@varkey98 varkey98 merged commit e8225ec into main Jul 25, 2024
5 of 7 checks passed
@varkey98 varkey98 deleted the filter-result-decorations branch July 25, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants