-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding generic attributes interface #217
Conversation
We would need to use fmt.Sprintf before passing the values to the filter, shall we just store the attributes as strings itself in that case? @ryanericson @tim-mwangi |
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 58.81% 58.94% +0.12%
==========================================
Files 55 55
Lines 2229 2236 +7
==========================================
+ Hits 1311 1318 +7
Misses 859 859
Partials 59 59
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @ryanericson please take a look as well since you were the original author for this :)
Description
Adding a generic GetAll method for attributes so that all the attributes can be queried at once
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.