Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update buf #260

Merged
merged 2 commits into from
Dec 6, 2024
Merged

chore: update buf #260

merged 2 commits into from
Dec 6, 2024

Conversation

aaron-steinfeld
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 6, 2024

The latest Buf updates on your PR. Results from workflow test / validate-protos-temp (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 6, 2024, 5:53 PM

Copy link

github-actions bot commented Dec 6, 2024

Test Results

134 tests  ±0   134 ✅ ±0   1m 2s ⏱️ +2s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 8ca45b4. ± Comparison against base commit 681e7e5.

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review December 6, 2024 18:33
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner December 6, 2024 18:33
github_token: ${{ github.token }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want you can use setup_only: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This automatically runs all the checks though - why use it as setup only unless we needed something real custom?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I figured :) I did not need the rest since I was calling buf build directly in make for TPA

@aaron-steinfeld aaron-steinfeld merged commit 2279700 into main Dec 6, 2024
9 checks passed
@aaron-steinfeld aaron-steinfeld deleted the update-buf branch December 6, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants