Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert guice7 to guice6 #248

Merged
merged 2 commits into from
Oct 25, 2024
Merged

revert guice7 to guice6 #248

merged 2 commits into from
Oct 25, 2024

Conversation

surajpuvvada
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@surajpuvvada surajpuvvada requested a review from a team as a code owner October 24, 2024 20:50
Copy link

github-actions bot commented Oct 24, 2024

Test Results

134 tests  ±0   134 ✅ ±0   1m 0s ⏱️ -2s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 24ee9ca. ± Comparison against base commit 964bca6.

♻️ This comment has been updated with latest results.

@aaron-steinfeld aaron-steinfeld dismissed their stale review October 24, 2024 20:54

will need updated locks

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.28%. Comparing base (7a59a85) to head (24ee9ca).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #248      +/-   ##
============================================
- Coverage     79.93%   77.28%   -2.65%     
- Complexity      496      537      +41     
============================================
  Files            55       59       +4     
  Lines          2432     2589     +157     
  Branches        108      121      +13     
============================================
+ Hits           1944     2001      +57     
- Misses          427      518      +91     
- Partials         61       70       +9     
Flag Coverage Δ
integration ?
unit 77.28% <ø> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaron-steinfeld aaron-steinfeld merged commit 3088579 into main Oct 25, 2024
10 of 11 checks passed
@aaron-steinfeld aaron-steinfeld deleted the revert_to_guice6 branch October 25, 2024 12:04
surajpuvvada added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants