Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support to delete system label application rule #236

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

saxenakshitiz
Copy link
Contributor

No description provided.

@saxenakshitiz saxenakshitiz requested a review from a team as a code owner September 2, 2024 13:47
Copy link

github-actions bot commented Sep 2, 2024

Test Results

134 tests  +2   134 ✅ +2   55s ⏱️ ±0s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 18120c3. ± Comparison against base commit 834e663.

♻️ This comment has been updated with latest results.

aaron-steinfeld
aaron-steinfeld previously approved these changes Sep 2, 2024
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change expected due to new proto module

import org.hypertrace.config.service.v1.ConfigServiceGrpc.ConfigServiceBlockingStub;
import org.hypertrace.label.application.rule.config.service.impl.v1.DeletedSystemLabelApplicationRule;

public class DeletedSystemLabelApplicationRuleStore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - package private

@aaron-steinfeld aaron-steinfeld merged commit b5cf2f4 into main Sep 2, 2024
8 of 9 checks passed
@aaron-steinfeld aaron-steinfeld deleted the support_system_rule_deletion branch September 2, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants