Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ConfigMetricReporter to report metrics around configs #232

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

sanket-mundra
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from a team as a code owner August 28, 2024 10:56
Copy link

github-actions bot commented Aug 28, 2024

Test Results

127 tests  ±0   127 ✅ ±0   58s ⏱️ -1s
 30 suites ±0     0 💤 ±0 
 30 files   ±0     0 ❌ ±0 

Results for commit ec29458. ± Comparison against base commit aec20fe.

♻️ This comment has been updated with latest results.

suresh-prakash
suresh-prakash previously approved these changes Aug 29, 2024
@sanket-mundra sanket-mundra enabled auto-merge (squash) August 30, 2024 12:35
@sanket-mundra sanket-mundra merged commit 9519fa1 into main Aug 30, 2024
9 checks passed
@sanket-mundra sanket-mundra deleted the sanket/addConfigMetricReporter branch August 30, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants