ENG-48446: Implementation for new Filter condition and filter conversion

[harshit-kumar-v2]

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

[aaron-steinfeld]

We should probably treat this the same as an update operation where the condition doesn't hold. At least the same status, even if a specific message.

[aaron-steinfeld]

So given the latest change, that'd be a failed precondition

[github-actions]

Test Results

127 tests  +5   127 ✅ +5   55s ⏱️ -3s
 30 suites +1     0 💤 ±0 
 30 files   +1     0 ❌ ±0 

Results for commit cdbd390. ± Comparison against base commit 7a59a85.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.

org.hypertrace.config.service.store.DocumentConfigStoreTest ‑ writeConfig()

org.hypertrace.config.service.store.DocumentConfigStoreTest ‑ WriteConfigForCreate()
org.hypertrace.config.service.store.DocumentConfigStoreTest ‑ WriteConfigForUpdateWithUpsertCondition()
org.hypertrace.config.service.store.DocumentConfigStoreTest ‑ WriteConfigForUpdateWithoutUpsertCondition()
org.hypertrace.config.service.store.FilterBuilderTest ‑ buildDocStoreFilter1()
org.hypertrace.config.service.store.FilterBuilderTest ‑ buildDocStoreFilter2()
org.hypertrace.config.service.store.FilterBuilderTest ‑ buildDocStoreFilter3()

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: Patch coverage is 63.38028% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (49d70b0) to head (718756f).
Report is 15 commits behind head on main.

Files	Patch %	Lines
...hypertrace/config/service/store/FilterBuilder.java	59.25%	19 Missing and 3 partials ⚠️
...race/config/service/store/DocumentConfigStore.java	75.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #228      +/-   ##
============================================
- Coverage     79.92%   79.52%   -0.40%     
+ Complexity      488      407      -81     
============================================
  Files            54       56       +2     
  Lines          2416     2496      +80     
  Branches        106      110       +4     
============================================
+ Hits           1931     1985      +54     
- Misses          425      446      +21     
- Partials         60       65       +5     

Flag	Coverage Δ
integration	79.52% <63.38%> (-0.40%)	⬇️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aaron-steinfeld]

So given the latest change, that'd be a failed precondition

[aaron-steinfeld]

In this PR or another - it'd be good to move this filter building into the filter builder class now that there's a dedicated class for it.

[harshit-kumar-v2]

ok making those refactor in a different PR