Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore | Proto changes for adding evaluation targets for each exclude span rule" #219

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Revert "chore | Proto changes for adding evaluation targets for each exclude span rule" #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions ...oto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
syntax = "proto3";

Check failure on line 1 in span-processing-config-service-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto

View workflow job for this annotation

GitHub Actions / validate-protos 

Previously present message "Agent" was deleted from package "org.hypertrace.span.processing.config.service.v1".

Check failure on line 1 in span-processing-config-service-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto

View workflow job for this annotation

GitHub Actions / validate-protos 

Previously present message "AgentModule" was deleted from package "org.hypertrace.span.processing.config.service.v1".

Check failure on line 1 in span-processing-config-service-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto

View workflow job for this annotation

GitHub Actions / validate-protos 

Previously present message "EvaluationTarget" was deleted from package "org.hypertrace.span.processing.config.service.v1".

Check failure on line 1 in span-processing-config-service-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto

View workflow job for this annotation

GitHub Actions / validate-protos 

Previously present message "Platform" was deleted from package "org.hypertrace.span.processing.config.service.v1".

package org.hypertrace.span.processing.config.service.v1;

Expand Down Expand Up @@ -61,28 +61,13 @@
ExcludeSpanRuleMetadata metadata = 2;
}

message ExcludeSpanRuleInfo {

Check failure on line 64 in span-processing-config-service-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto

View workflow job for this annotation

GitHub Actions / validate-protos 

Previously present field "5" with name "evaluation_targets" on message "ExcludeSpanRuleInfo" was deleted.

Check failure on line 64 in span-processing-config-service-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto

View workflow job for this annotation

GitHub Actions / validate-protos 

Previously present field "5" with name "evaluation_targets" on message "ExcludeSpanRuleInfo" was deleted without reserving the name "evaluation_targets".

Check failure on line 64 in span-processing-config-service-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto

View workflow job for this annotation

GitHub Actions / validate-protos 

Previously present field "5" with name "evaluation_targets" on message "ExcludeSpanRuleInfo" was deleted without reserving the number "5".
string name = 1;
SpanFilter filter = 2;
bool disabled = 3;
RuleType type = 4;
repeated EvaluationTarget evaluation_targets = 5;
}

message EvaluationTarget {
oneof target {
Platform platform = 1;
Agent agent = 2;
AgentModule agent_module = 3;
}
}

message Platform {}

message Agent {}

message AgentModule {}

message ExcludeSpanRuleMetadata {
google.protobuf.Timestamp creation_timestamp = 1;
google.protobuf.Timestamp last_updated_timestamp = 2;
Expand Down
Loading