Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label rules for backends #205

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Conversation

sanket-mundra
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from a team as a code owner March 12, 2024 05:52
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.92%. Comparing base (76580e4) to head (615cbc2).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #205   +/-   ##
=========================================
  Coverage     79.92%   79.92%           
  Complexity      488      488           
=========================================
  Files            54       54           
  Lines          2416     2416           
  Branches        106      106           
=========================================
  Hits           1931     1931           
  Misses          425      425           
  Partials         60       60           
Flag Coverage Δ
integration 79.92% <ø> (ø)
unit 78.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 12, 2024

Test Results

120 tests  ±0   120 ✅ ±0   59s ⏱️ -1s
 29 suites ±0     0 💤 ±0 
 29 files   ±0     0 ❌ ±0 

Results for commit 615cbc2. ± Comparison against base commit 76580e4.

♻️ This comment has been updated with latest results.

skjindal93
skjindal93 previously approved these changes Mar 12, 2024
@sanket-mundra sanket-mundra merged commit d3e5ac9 into main Mar 22, 2024
11 checks passed
@sanket-mundra sanket-mundra deleted the sanket/exposeBackendForLabelRule branch March 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants