Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore | delete configs permanently rather than soft deletes #178

Merged
merged 15 commits into from
Oct 12, 2023

Conversation

aman-bansal
Copy link
Member

No description provided.

@aman-bansal aman-bansal requested a review from a team as a code owner October 11, 2023 05:50
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #178 (d5fd3d1) into main (bafa898) will decrease coverage by 0.16%.
Report is 2 commits behind head on main.
The diff coverage is 92.45%.

@@             Coverage Diff              @@
##               main     #178      +/-   ##
============================================
- Coverage     79.93%   79.78%   -0.16%     
  Complexity      478      478              
============================================
  Files            54       54              
  Lines          2382     2384       +2     
  Branches        104      103       -1     
============================================
- Hits           1904     1902       -2     
  Misses          420      420              
- Partials         58       62       +4     
Flag Coverage Δ
integration 79.78% <92.45%> (-0.16%) ⬇️
unit 78.29% <88.67%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pertrace/config/service/ConfigServiceGrpcImpl.java 86.48% <100.00%> (+1.51%) ⬆️
.../hypertrace/config/service/ConfigServiceUtils.java 93.22% <ø> (ø)
...race/config/service/store/DocumentConfigStore.java 90.38% <86.20%> (-4.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Test Results

116 tests  +1   116 ✔️ +1   1m 15s ⏱️ +2s
  29 suites ±0       0 💤 ±0 
  29 files   ±0       0 ±0 

Results for commit d5fd3d1. ± Comparison against base commit b58a082.

♻️ This comment has been updated with latest results.

skjindal93
skjindal93 previously approved these changes Oct 11, 2023
this.store = configStore;
return configStore;
} catch (Exception e) {
throw new RuntimeException("Error in getting or initializing config store", e);
}
}

private Datastore initDataStore(Config config) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - we can come back to this, but I believe latest doc store has a new interface here.

@aman-bansal aman-bansal merged commit 73e3e05 into main Oct 12, 2023
9 of 10 checks passed
@aman-bansal aman-bansal deleted the aman/fix_config branch October 12, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants