-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore | delete configs permanently rather than soft deletes #178
Conversation
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
============================================
- Coverage 79.93% 79.78% -0.16%
Complexity 478 478
============================================
Files 54 54
Lines 2382 2384 +2
Branches 104 103 -1
============================================
- Hits 1904 1902 -2
Misses 420 420
- Partials 58 62 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/ConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/store/DocumentConfigStore.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
config-service-impl/src/main/java/org/hypertrace/config/service/ConfigServiceGrpcImpl.java
Show resolved
Hide resolved
this.store = configStore; | ||
return configStore; | ||
} catch (Exception e) { | ||
throw new RuntimeException("Error in getting or initializing config store", e); | ||
} | ||
} | ||
|
||
private Datastore initDataStore(Config config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - we can come back to this, but I believe latest doc store has a new interface here.
No description provided.