feat: added syslog support in notification channel

hypertrace · Oct 14, 2023 · 47c4d1d · 47c4d1d
1 parent 73e3e05
commit 47c4d1d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/...i/src/main/proto/org/hypertrace/notification/config/service/v1/notification_channel.proto b/...i/src/main/proto/org/hypertrace/notification/config/service/v1/notification_channel.proto
@@ -15,6 +15,7 @@ message NotificationChannelMutableData {
   repeated WebhookChannelConfig webhook_channel_config = 3;
   repeated AwsS3BucketChannelConfig s3_bucket_channel_config = 4;
   repeated SplunkIntegrationChannelConfig splunk_integration_channel_config = 5;
+  repeated SyslogIntegrationChannelConfig syslog_integration_channel_config = 6;
 }
 
 message AwsS3BucketChannelConfig {
@@ -55,3 +56,7 @@ message WebhookHeader {
 message SplunkIntegrationChannelConfig {
   string splunk_integration_id = 1;
 }
+
+message SyslogIntegrationChannelConfig {
+  string syslog_server_integration_id = 1;
+}
diff --git a/...ertrace/notification/config/service/NotificationChannelConfigServiceRequestValidator.java b/...ertrace/notification/config/service/NotificationChannelConfigServiceRequestValidator.java
@@ -18,6 +18,7 @@
 import org.hypertrace.notification.config.service.v1.GetNotificationChannelRequest;
 import org.hypertrace.notification.config.service.v1.NotificationChannelMutableData;
 import org.hypertrace.notification.config.service.v1.SplunkIntegrationChannelConfig;
+import org.hypertrace.notification.config.service.v1.SyslogIntegrationChannelConfig;
 import org.hypertrace.notification.config.service.v1.UpdateNotificationChannelRequest;
 import org.hypertrace.notification.config.service.v1.WebhookChannelConfig;
 import org.hypertrace.notification.config.service.v1.WebhookHeader;
@@ -112,14 +113,17 @@ private void validateNotificationChannelMutableData(NotificationChannelMutableDa
     if (data.getEmailChannelConfigCount() == 0
         && data.getWebhookChannelConfigCount() == 0
         && data.getS3BucketChannelConfigCount() == 0
-        && data.getSplunkIntegrationChannelConfigCount() == 0) {
+        && data.getSplunkIntegrationChannelConfigCount() == 0
+        && data.getSyslogIntegrationChannelConfigCount() == 0) {
       throw Status.INVALID_ARGUMENT.withDescription("No config present").asRuntimeException();
     }
     data.getEmailChannelConfigList().forEach(this::validateEmailChannelConfig);
     data.getWebhookChannelConfigList().forEach(this::validateWebhookChannelConfig);
     data.getS3BucketChannelConfigList().forEach(this::validateS3BucketConfig);
     data.getSplunkIntegrationChannelConfigList()
         .forEach(this::validateSplunkIntegrationChannelConfig);
+    data.getSyslogIntegrationChannelConfigList()
+        .forEach(this::validateSyslogIntegrationChannelConfig);
   }
 
   public void validateGetAllNotificationChannelsRequest(
@@ -180,4 +184,11 @@ private void validateSplunkIntegrationChannelConfig(
         splunkIntegrationChannelConfig,
         SplunkIntegrationChannelConfig.SPLUNK_INTEGRATION_ID_FIELD_NUMBER);
   }
+
+  private void validateSyslogIntegrationChannelConfig(
+      SyslogIntegrationChannelConfig syslogIntegrationChannelConfig) {
+    validateNonDefaultPresenceOrThrow(
+        syslogIntegrationChannelConfig,
+        SyslogIntegrationChannelConfig.SYSLOG_SERVER_INTEGRATION_ID_FIELD_NUMBER);
+  }
 }