Expose URL_PATH in exclusion rules (#201)

hypertrace · Feb 14, 2024 · 2cae628 · 2cae628
1 parent e414d22
commit 2cae628
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/...ice-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_filter.proto b/...ice-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_filter.proto
@@ -47,6 +47,7 @@ enum Field {
   FIELD_URL = 1;
   FIELD_SERVICE_NAME = 2;
   FIELD_ENVIRONMENT_NAME = 3;
+  FIELD_URL_PATH = 4;
 }
 
 enum RelationalOperator {

diff --git a/...va/org/hypertrace/span/processing/config/service/SpanProcessingConfigServiceImplTest.java b/...va/org/hypertrace/span/processing/config/service/SpanProcessingConfigServiceImplTest.java
@@ -1,6 +1,7 @@
 package org.hypertrace.span.processing.config.service;
 
 import static org.hypertrace.span.processing.config.service.v1.Field.FIELD_URL;
+import static org.hypertrace.span.processing.config.service.v1.Field.FIELD_URL_PATH;
 import static org.hypertrace.span.processing.config.service.v1.LogicalOperator.LOGICAL_OPERATOR_AND;
 import static org.hypertrace.span.processing.config.service.v1.RelationalOperator.RELATIONAL_OPERATOR_CONTAINS;
 import static org.hypertrace.span.processing.config.service.v1.RuleType.RULE_TYPE_SYSTEM;
@@ -284,6 +285,18 @@ private ExcludeSpanRule buildMockSystemExcludeSpanRule(boolean disabled) {
                                                         .build())
                                                 .build())
                                         .build())
+                                .addOperands(
+                                    SpanFilter.newBuilder()
+                                        .setRelationalSpanFilter(
+                                            RelationalSpanFilterExpression.newBuilder()
+                                                .setOperator(RELATIONAL_OPERATOR_CONTAINS)
+                                                .setField(FIELD_URL_PATH)
+                                                .setRightOperand(
+                                                    SpanFilterValue.newBuilder()
+                                                        .setStringValue("health")
+                                                        .build())
+                                                .build())
+                                        .build())
                                 .build())
                         .build())
                 .build())
@@ -324,6 +337,15 @@ private Config buildMockConfig() {
                                                 "operator",
                                                 "RELATIONAL_OPERATOR_CONTAINS",
                                                 "right_operand",
+                                                Map.of("string_value", "health"))),
+                                        Map.of(
+                                            "relational_span_filter",
+                                            Map.of(
+                                                "field",
+                                                "FIELD_URL_PATH",
+                                                "operator",
+                                                "RELATIONAL_OPERATOR_CONTAINS",
+                                                "right_operand",
                                                 Map.of("string_value", "health"))))))))))));
   }
 }