chore: marking trace, span related ids as non-groupable #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotharironak
requested review from
satish-mittal,
aaron-steinfeld,
laxmanchekka,
arjunlalb and
mihirgt
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
=========================================
Coverage 74.10% 74.10%
Complexity 69 69
=========================================
Files 14 14
Lines 560 560
Branches 34 34
=========================================
Hits 415 415
Misses 128 128
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
kotharironak
commented
Nov 7, 2023
| @@ -12,7 +12,7 @@ commands = [ | |||
| fqn: Span.id, | |||
| key: id, | |||
| value_kind: TYPE_STRING, | |||
| groupable: true, | |||
| groupable: false, | |||
There was a problem hiding this comment.
Do I need to add rollback block with action update to go back to true value?
There was a problem hiding this comment.
Yes, but also you shouldn't change a historical command. You want to add a new command with its own rollback that describes the desired and previous state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'groupable' field in attribute definition helps determine whether that attribute is used for grouping, mainly in a time-series context. Since span/trace IDs are unique values, it doesn't make much sense, as the time-series will mostly result in a count of 1.
This is also causing some performance issues and results in an error when used in conjunction with DistinctCountHLL. As part of this PR, we are moving them into the non-groupable category.