Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize initContainers image #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomassatka
Copy link

Description

Parameterize initContainers image. Even that image is simply busybox enabling configuring the image enable installing from different repo (perhaps company repo) that is not blocked by fw. By default busybox would be fetched from dockerhub that is not always allowed. This PR enables the option to override by helmfile for easier orchestration.

Testing

Tested by helm template

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #64 (cc17e4b) into main (9ee65a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #64   +/-   ##
=========================================
  Coverage     74.50%   74.50%           
  Complexity       69       69           
=========================================
  Files            14       14           
  Lines           557      557           
  Branches         33       33           
=========================================
  Hits            415      415           
  Misses          126      126           
  Partials         16       16           
Flag Coverage Δ
integration 74.50% <ø> (ø)
unit 43.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee65a1...cc17e4b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant