fix: add backwards compatibility to internal filter (#107)

hypertrace · Sep 27, 2021 · 0316e85 · 0316e85
1 parent 8baa62e
commit 0316e85
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/...ervice-impl/src/main/java/org/hypertrace/core/attribute/service/AttributeServiceImpl.java b/...ervice-impl/src/main/java/org/hypertrace/core/attribute/service/AttributeServiceImpl.java
@@ -388,8 +388,13 @@ private Query getQueryForFilter(
     }
 
     if (attributeMetadataFilter.hasInternal()) {
-      andFilters.add(
-          new Filter(Op.EQ, ATTRIBUTE_INTERNAL_KEY, attributeMetadataFilter.getInternal()));
+      Filter internalFilter =
+          new Filter(Op.EQ, ATTRIBUTE_INTERNAL_KEY, attributeMetadataFilter.getInternal());
+      if (!attributeMetadataFilter.getInternal()) {
+        // For backwards compatibility, treat an attribute missing internal attribute as external
+        internalFilter = internalFilter.or(new Filter(Op.NOT_EXISTS, ATTRIBUTE_INTERNAL_KEY, null));
+      }
+      andFilters.add(internalFilter);
     }
 
     Filter queryFilter = new Filter();