better session disposal #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
| @@ -134,4 +135,5 @@ func (s *localSession) Receive() <-chan *view.Message { | |||
|
|
|||
| func (s *localSession) Close() { | |||
| s.info.Closed = true | |||
| s.info.WhoClosed = string(debug.Stack()) | |||
There was a problem hiding this comment.
I guess the WhoClosed was used for debugging the disposable session.
adecaro
requested review from
alexandrosfilios and
mbrandenburger
and removed request for
mbrandenburger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a better strategy to dispose communication sessions. It also tracks who disposed the session.