-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: request to https if the tls is enabled #438
Conversation
Thanks @Sanket-0510, I've approved the CI run. If CI tests fail, it means you need to also update snapshots. Just run locally:
And commit changes. Fablo doesn't have local dev docs with that information yet (sorry for that). We have an issue to handle that: #436. |
Is this fine now? |
Let's see if CI passes. Also the DCO check fails, because all commits needs to contain DCO sign-off: https://wiki.linuxfoundation.org/dco You need to either squash or update commits, and then force push. |
I squashed the commit, and have signed it. Also I have ran the e2e test command, tests pass successfully |
Hey @dzikowski any idea why the tests are failing cause I guess I have done the changes at correct location, also I've ran e2e test also, nothing is failing locally! |
Signed-off-by: Sanket <[email protected]> added the snapshots
I have rebased my dev branch with fablo's updated main branch, I hope this will solve the problem |
fixes: #437 if TLS is enabled all requests are directed to the HTTPS.