Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request to https if the tls is enabled #438

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Sanket-0510
Copy link
Contributor

@Sanket-0510 Sanket-0510 commented Apr 9, 2024

fixes: #437 if TLS is enabled all requests are directed to the HTTPS.

@dzikowski
Copy link
Contributor

Thanks @Sanket-0510, I've approved the CI run. If CI tests fail, it means you need to also update snapshots. Just run locally:

npm run test:e2e-update

And commit changes. Fablo doesn't have local dev docs with that information yet (sorry for that). We have an issue to handle that: #436.

@Sanket-0510
Copy link
Contributor Author

Thanks @Sanket-0510, I've approved the CI run. If CI tests fail, it means you need to also update snapshots. Just run locally:

npm run test:e2e-update

And commit changes. Fablo doesn't have local dev docs with that information yet (sorry for that). We have an issue to handle that: #436.

Is this fine now?

@dzikowski
Copy link
Contributor

dzikowski commented Apr 9, 2024

Let's see if CI passes. Also the DCO check fails, because all commits needs to contain DCO sign-off: https://wiki.linuxfoundation.org/dco

You need to either squash or update commits, and then force push.

@Sanket-0510
Copy link
Contributor Author

Sanket-0510 commented Apr 9, 2024

Let's see if CI passes. Also the DCO check fails, because all commits needs to contain DCO sign-off: https://wiki.linuxfoundation.org/dco

You need to either squash or update commits, and then force push.

I squashed the commit, and have signed it. Also I have ran the e2e test command, tests pass successfully

@Sanket-0510
Copy link
Contributor Author

Hey @dzikowski any idea why the tests are failing cause I guess I have done the changes at correct location, also I've ran e2e test also, nothing is failing locally!

@dzikowski
Copy link
Contributor

test-k8 fails, because those are still in progress: #425 and #431

test-03-private-data fails, because it's a bit outdated, and we eventually want to remove this check: #396

test-04-snapshot should be fixed on main branch now, once you merge, it should pass

Signed-off-by: Sanket <[email protected]>

added the snapshots
@Sanket-0510
Copy link
Contributor Author

Sanket-0510 commented Apr 9, 2024

test-k8 fails, because those are still in progress: #425 and #431

test-03-private-data fails, because it's a bit outdated, and we eventually want to remove this check: #396

test-04-snapshot should be fixed on main branch now, once you merge, it should pass

I have rebased my dev branch with fablo's updated main branch, I hope this will solve the problem

@dzikowski dzikowski merged commit 21d1a35 into hyperledger-labs:main Apr 10, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA URLs in connection profiles contain http even if TLS is enabled
2 participants