Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional protojson marshal options. #34

Closed
wants to merge 1 commit into from

Conversation

Nova38
Copy link

@Nova38 Nova38 commented May 19, 2023

This is in relation to issue #31 and storing the state a json objects. This exposes two additional options for json serialization and enables them by default for the json sterilization. The first option has it encode the enums as an int instead of a string. This will reduce the size of the objects stored in the ledger. The second option is to enable it to encode default values when translating the proto to json. This will ensure that the objects in the CouchDB will have the expected shape so that rich queries can be ran on the world state db for objects that have default values.

@Nova38 Nova38 requested a review from a team as a code owner May 19, 2023 18:53
@vitiko
Copy link
Contributor

vitiko commented May 24, 2023

@Nova38 your changes are welcome, but need to check / update tests and add DCO

@Nova38 Nova38 closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants