Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FPC_ENABLED #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for FPC_ENABLED #74

wants to merge 2 commits into from
+45 −11

Conversation

osamamagdy
Copy link

No description provided.

@osamamagdy
Add support for FPC_ENABLED
9fee652 
Signed-off-by: Osama Magdy <[email protected]>
@osamamagdy osamamagdy requested a review from a team as a code owner September 27, 2024 15:17
samuelvenzi
samuelvenzi requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@samuelvenzi samuelvenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the FPC dependency (and its correct version) to go.mod.

@osamamagdy osamamagdy force-pushed the feat/add-env-for-fpc branch from 36c98c4 to 336ef14 Compare October 10, 2024 14:33
@osamamagdy
Add FPC to go.mod
976c1e8 
Signed-off-by: osamamagdy <[email protected]>
@osamamagdy osamamagdy force-pushed the feat/add-env-for-fpc branch from 336ef14 to 976c1e8 Compare October 10, 2024 14:34
@osamamagdy
Copy link
Author

@samuelvenzi done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelvenzi samuelvenzi samuelvenzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osamamagdy @samuelvenzi