refactor: Umbrella Iroha CLI Pt. I #5274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoyako
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
aoyako
changed the title
aoyako
changed the title
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
s8sato
reviewed
Dec 27, 2024
There was a problem hiding this comment.
I recommend starting by aiming to reduce them to three binaries -- daemon, client, and dev tools. Further steps seem to be still controversial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4969
This PR is the 1st part of the unification of cli tools into the
irohatool (#4969 (comment)).Changes introduced extend the default scope of
irohaby adding:iroha codec (types, json-to-scale, scale-to-json, scale-to-rust)iroha wasm (check, build, test)iroha client (same as regular iroha before)Documentation in the readme is updated as well. I believe the documentation update on the website will be updated afterward.
More on updates:
iroha clientwas well designed and mostly left intact, but as for other commands, the approach of callingrunon arguments is adopted.README.mdis fixed to be one for theirohacli, but it refers to other readmes explaining the usage of subcommand in detail.crates/intosamples/(probably related to Contrast/cratesand/samples#5225)