fix: build_wasm copy executor to defaults #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoyako
requested review from
s8sato,
mversic,
SamHSmith,
0x009922 and
dima74
as code owners
dima74
approved these changes
Oct 30, 2024
Signed-off-by: Lohachov Mykhailo <[email protected]>
aoyako
force-pushed
the
fix_build_wasm_copy
branch
from
68e537f to
a0a5d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix the
build_wasm.shscript to copy generated wasm files to thedefaultsfolder. The issue is currently reproducible on macOS.Checklist
CONTRIBUTING.md.