Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4350: Expose event set bitfields in schema #4381

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

DCNick3
Copy link
Contributor

@DCNick3 DCNick3 commented Mar 22, 2024

Description

Add a new kind of schema metadata - BitmapMeta - and use it to expose *EventSet bitfields in schema

Linked issue

Closes #4350

Checklist

  • make ci pass

@github-actions github-actions bot added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries labels Mar 22, 2024
@coveralls
Copy link

coveralls commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8433022413

Details

  • 37 of 52 (71.15%) changed or added relevant lines in 3 files are covered.
  • 5030 unchanged lines in 91 files lost coverage.
  • Overall coverage increased (+0.8%) to 57.63%

Changes Missing Coverage Covered Lines Changed/Added Lines %
schema/src/lib.rs 0 2 0.0%
schema/src/serialize.rs 2 15 13.33%
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
primitives/src/addr.rs 3 64.04%
config/src/logger.rs 5 72.73%
Totals Coverage Status
Change from base Build 7884695009: 0.8%
Covered Lines: 23136
Relevant Lines: 40146

💛 - Coveralls

@mversic mversic self-requested a review March 26, 2024 08:30
@mversic mversic merged commit 1f0e21d into hyperledger-iroha:iroha2-dev Mar 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants