Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4292, #4327: Docker follow-up on configuration update #4367

Merged

Conversation

0x009922
Copy link
Contributor

Description

  • Actualised Dockerfile(s)
  • Added actual parsing of SUMERAGI_TRUSTED_PEERS env
  • Refactor guts of config implementation

Linked issue

Closes #4292, #4327

@0x009922 0x009922 added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha CI labels Mar 14, 2024
@0x009922 0x009922 self-assigned this Mar 14, 2024
Copy link

@BAStos525

@0x009922 0x009922 force-pushed the 4292-docker-and-config branch from 8c7c6e7 to 531600c Compare March 15, 2024 00:43
@coveralls
Copy link

coveralls commented Mar 15, 2024

Pull Request Test Coverage Report for Build 8335863492

Details

  • 90 of 95 (94.74%) changed or added relevant lines in 3 files are covered.
  • 4578 unchanged lines in 88 files lost coverage.
  • Overall coverage increased (+0.7%) to 57.502%

Changes Missing Coverage Covered Lines Changed/Added Lines %
config/base/src/lib.rs 51 56 91.07%
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
primitives/src/addr.rs 3 64.04%
schema/derive/src/lib.rs 5 83.25%
Totals Coverage Status
Change from base Build 7884695009: 0.7%
Covered Lines: 22798
Relevant Lines: 39647

💛 - Coveralls

@s8sato s8sato self-assigned this Mar 18, 2024
@0x009922 0x009922 force-pushed the 4292-docker-and-config branch from 531600c to 8fa0324 Compare March 19, 2024 01:00
@0x009922 0x009922 merged commit ac872b2 into hyperledger-iroha:iroha2-dev Mar 19, 2024
12 checks passed
@0x009922 0x009922 deleted the 4292-docker-and-config branch March 19, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working CI config-changes Changes in configuration and start up of the Iroha iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants