Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4126: test to prevent cross chain replay attacks #4342

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

timofeevmd
Copy link
Contributor

Description

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@timofeevmd timofeevmd self-assigned this Mar 5, 2024
@github-actions github-actions bot added Refactor Improvement to overall code quality iroha2-dev The re-implementation of a BFT hyperledger in RUST and removed Refactor Improvement to overall code quality labels Mar 5, 2024
Erigara
Erigara previously approved these changes Mar 5, 2024
Asem-Abdelhady
Asem-Abdelhady previously approved these changes Mar 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8204197922

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3993 unchanged lines in 68 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.772%

Files with Coverage Reduction New Missed Lines %
tools/kagami/src/crypto.rs 1 12.12%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/lib.rs 1 0.0%
primitives/src/unique_vec.rs 2 91.24%
data_model/src/metadata.rs 2 78.87%
config/src/kura.rs 3 80.0%
logger/src/lib.rs 5 94.12%
config/src/logger.rs 5 72.73%
tools/kagami/src/main.rs 5 0.0%
telemetry/src/dev.rs 7 0.0%
Totals Coverage Status
Change from base Build 7884695009: -0.02%
Covered Lines: 22431
Relevant Lines: 39511

💛 - Coveralls

@mversic mversic merged commit 600d74c into hyperledger-iroha:iroha2-dev Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants